cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 67 forks source link

Translate strings to Russian #88

Closed akaDuality closed 2 years ago

akaDuality commented 2 years ago

We are going to use the library in our application and would like to translate text to Russian.

I have two questions:

NickEntin commented 2 years ago

Hey @akaDuality, thanks for your interest in AccessibilitySnapshot! If you look at the "Data Table" screen in the sample app, the B3 cell spans 2 rows.

@jhneves Mind taking a look at the conversion to stringsdict?

jhneves commented 2 years ago

@akaDuality yes it's fine to update to .stringsdict, I will find out someone to help with the German translation.

akaDuality commented 2 years ago

Thank you, I'll add .stringsdict to this PR in a few days

akaDuality commented 2 years ago

I've understand that there is no need in plurals right now. English version can't "span 1 row" and Russian version has format that avoids plurals at all.

I updated localisation and all strings are correct now and can be merged.

jhneves commented 2 years ago

@akaDuality sounds good!

jhneves commented 2 years ago

@akaDuality looks great, one last step to contribute is to sign here, please take a look and let me know.

akaDuality commented 2 years ago

@jhneves Done!

jhneves commented 2 years ago

Thank you @akaDuality !

akaDuality commented 2 years ago

Thank you for approving!

Do you have any plans on release?

jhneves commented 2 years ago

we're working on that @akaDuality, should be out very soon.