search

cashapp / AccessibilitySnapshot

Easy regression testing for iOS accessibility
Apache License 2.0
541 stars 67 forks source link

Fix and add tests for iOS 15 devices #91

Closed luispadron closed 2 years ago

luispadron commented 2 years ago

Summary

The fishhook.c code in the repository had started crashing for iOS 15 devices. I copied the contents from the .c file from the fix in this PR: https://github.com/facebook/fishhook/pull/87

I also attempted to add tests for iOS 15, not sure if I added them correctly to CI but I generated the snapshots and tested locally with iOS 15.2 iPhone 13 Pro.

luispadron commented 2 years ago

@NickEntin @jhneves 🙏🏼

jhneves commented 2 years ago

diff appears fine to me, but definitely worth having @NickEntin 👀 on this one. The CI seems like does not have xcode 13.2 though @luispadron ?

luispadron commented 2 years ago

@jhneves Thanks for checking! Yeah I'm not entirely sure how to use new Xcode with GitHub actions, I'll defer to @NickEntin here 🙏🏼

Edit: Updated to use 13.2.1 since it looks like that should work: https://github.com/actions/virtual-environments/issues/4769