search

cashapp / burst

Burst is a unit testing library that uses enums to parameterize unit tests
Apache License 2.0
19 stars 1 forks source link

Support Junit 5 #35

Open Goooler opened 4 days ago

Goooler commented 4 days ago 
No ParameterResolver registered for parameter [io.github.goooler.exporter.IntegrationTest$TestCase arg0] in constructor [public io.github.goooler.exporter.IntegrationTest(io.github.goooler.exporter.IntegrationTest$TestCase)].
org.junit.jupiter.api.extension.ParameterResolutionException: No ParameterResolver registered for parameter [io.github.goooler.exporter.IntegrationTest$TestCase arg0] in constructor [public io.github.goooler.exporter.IntegrationTest(io.github.goooler.exporter.IntegrationTest$TestCase)].
    at java.util.Optional.orElseGet(Optional.java:267)
    at java.util.ArrayList.forEach(ArrayList.java:1259)
    at java.util.ArrayList.forEach(ArrayList.java:1259)

You can repro this at https://github.com/Goooler/StringResExporter/pull/114.

JakeWharton commented 4 days ago

We don't use JUnit 5, so this will probably have to come from a motivated external contributor.

swankjesse commented 3 days ago

Possibly accidentally fixed by making test classes ABSTRACT here: https://github.com/cashapp/burst/pulls

But we should add a JUnit 5 integration test to validate that.