search

cashapp / contour

Layouts with lambdas 😎
Apache License 2.0
1.53k stars 50 forks source link

Int.xdip/Int.ydip & Float.xdip/Float.ydip cause crash on Kotlin 1.4.30 #123

Closed luis-cortes closed 3 years ago

luis-cortes commented 3 years ago

This can be easily reproduced by changing the dependency on the sample app from the module to the binary: implementation project(':contour') -> implementation 'app.cash.contour:contour:1.0.0'

Here's the stack trace:

java.lang.NoSuchMethodError: No virtual method getYdip-dBGyhoQ(I)I in class 
Lcom/squareup/contour/sample/SampleView; or its super classes (declaration of 
'com.squareup.contour.sample.SampleView' appears in /data/app/~~0Ba-
93BI78uARYazH4agJA==/com.squareup.contour.sample-VKrVvhwusycb2ElCbF70RQ==/base.apk!classes2.dex)
        at com.squareup.contour.sample.SampleView$3.invoke(SampleView.kt:56)

Int.dip doesn't seem to be an issue.

At least on my project, reverting to 1.4.21 fixes the issue immediately.

luis-cortes commented 3 years ago

cc @saket @aerb

saket commented 3 years ago

We bumped up Kotlin to 1.4.30 but it's not released yet. Wanna try out 1.1.0-SNAPSHOT in the meantime?

omainegra commented 3 years ago

Do you have plans to release the stable 1.1.0 version soon? Kotlin 1.4.31 was already released last week. BTW snapshot version works fine

shekita88 commented 3 years ago

We bumped up Kotlin to 1.4.30 but it's not released yet. Wanna try out 1.1.0-SNAPSHOT in the meantime?

saket commented 3 years ago

Yep, we'll make a release soon!

oldergod commented 3 years ago

1.1.0 has been released.