search

cashapp / hermit-packages

Hermit manages isolated, self-bootstrapping sets of tools in software projects.
https://cashapp.github.io/hermit
120 stars 124 forks source link

`protoc-gen-connect-go` has moved #364

Open stillmatic opened 1 year ago

stillmatic commented 1 year ago

see https://github.com/connectrpc/connect-go/releases/tag/v1.11.0

One path to support would be just to update the org

However, the code doesn't appear to be backwards incompatible

cannot use greeter (variable of type *GreetServer) as ballonv1connect.BalloonServiceHandler value in argument to ballonv1connect.NewBalloonServiceHandler: *GreetServer does not implement ballonv1connect.BalloonServiceHandler (wrong type for method Greet)
        have Greet(context.Context, *"connectrpc.com/connect".Request[ballonv1.GreetRequest]) (*"connectrpc.com/connect".Response[ballonv1.GreetResponse], error)
        want Greet(context.Context, *"github.com/bufbuild/connect-go".Request[ballonv1.GreetRequest]) (*"github.com/bufbuild/connect-go".Response[ballonv1.GreetResponse], error)compiler[InvalidIfaceAssign](https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#InvalidIfaceAssign)

which is super fun to fix...

alecthomas commented 1 year ago

I don't think this should effect any current tooling or libraries right? The old code is still present AFAICT, and we build our own binaries for this.

stillmatic commented 1 year ago

it won't affect any current tooling - but it will keep those tools pinned on an older version of connect. the issue lies with supporting new versions of connect