search

cashapp / hermit-packages

Hermit manages isolated, self-bootstrapping sets of tools in software projects.
https://cashapp.github.io/hermit
120 stars 124 forks source link

fix: update ruff manifest #501

Closed gracevivi523 closed 3 months ago

gracevivi523 commented 3 months ago

ruff seems to have changed the download link, this PR to update the link and resume auto-update for ruff again.

reference from https://github.com/astral-sh/ruff/releases

tested locally by installing 3 different version from 3 different categories as they have slightly different source url as well as their packaging approach has changed slightly. image

gracevivi523 commented 3 months ago

To do so you will need to update all the sha256sums in the manifest file.

you will need to remove the existing entries and do hermit manifest add-digests {your package manifest}

Thank you @lyonlai.

Actually I think the links works for older version til 0.1.7, 0.1.8+ requires the the new link, is there a way that can cover both?

gracevivi523 commented 3 months ago

or maybe we do not need to worry about the old versions <=0.1.7, but will the change in this PR break existing repositories that are using ruff <=0.1.7 ?

alecthomas commented 3 months ago

Older versions need to remain, but you should be able to do exactly what @lyonlai suggested and everything "should" work barring weird issues.

damienrj commented 3 months ago

Older versions need to remain, but you should be able to do exactly what @lyonlai suggested and everything "should" work barring weird issues.

It looks like older versions should work since they have migrated them over as well. https://github.com/astral-sh/ruff/releases/tag/v0.1.7 For example.

gracevivi523 commented 3 months ago

It looks like older versions should work since they have migrated them over as well. https://github.com/astral-sh/ruff/releases/tag/v0.1.7 For example.

There is a slight difference, the older link has v before the version value v0.1.7, while the new link is not, it's 0.5.4 without v.

damienrj commented 3 months ago

It looks like older versions should work since they have migrated them over as well. https://github.com/astral-sh/ruff/releases/tag/v0.1.7 For example.

There is a slight difference, the older link has v before the version value v0.1.7, while the new link is not, it's 0.5.4 without v.

Yeah, the url change which you caught. I just meant that the binaries are still there.

gracevivi523 commented 3 months ago

PR is ready for 2nd round of review cc @lyonlai @alecthomas