cashapp / hermit

🐚 Hermit manages isolated, self-bootstrapping sets of tools in software projects.
https://cashapp.github.io/hermit
Apache License 2.0
602 stars 53 forks source link

sources git URL not supporting tags #287

Open rolandknight opened 2 years ago

rolandknight commented 2 years ago

The bin/hermit.hcl sources variable is not supporting repo tags. Example: sources = ["https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"]

Results in this error: fatal:hermit: /home/rolandknight/git/gitlab.com/onis-oss/tlc/sandbox/bin/hermit.hcl: unsupported source "https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"

alecthomas commented 2 years ago

Great point, we should definitely support that!

rolandknight commented 2 years ago

I can help with that. Can you point me to what needs to be changed?

On Jun 7, 2022, at 8:23 PM, Alec Thomas @.***> wrote:

 Great point, we should definitely support that!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

alecthomas commented 2 years ago

Oh nice, thank you. The code is currently living here, for downloading a package via git. I think this logic could be pulled out into a top-level git package, and reused by the package caching, and the sources.

jufemaiz commented 1 year ago

Happy to jump into this and assist. We're wanting to use atlas and unfortunately their latest release is git tag only – not github release.

alecthomas commented 1 year ago

I'm not sure what atlas is, but this issue is specifically talking about using git tags for extra package manifest sources, not for packages themselves.

If this is Atlas, you'd likely download the tarballs from their site. If you're talking about using tags for auto-versioning, a better option would be to use the html auto-versioning. This is also what we do for Go.

jufemaiz commented 1 year ago

@alecthomas thanks for the clarification! Taking up the need for an index page of releases with the Atlas team (it's this atlas for clarification).