fix: double-checked locking fail

cashapp / hermit

🐚 Hermit manages isolated, self-bootstrapping sets of tools in software projects.

https://cashapp.github.io/hermit

Apache License 2.0

600 stars 52 forks source link

fix: double-checked locking fail #392

Closed alecthomas closed 12 months ago

alecthomas commented 12 months ago

We use double-checked locking to avoid locks on the fast-path, but I modified the behaviour in #390 to cache the result before the lock, removing the second check. Face palm.

This fixes #391