search

cashapp / licensee

Gradle plugin which validates the licenses of your dependency graph match what you expect
https://cashapp.github.io/licensee/docs/1.x/
Apache License 2.0
637 stars 30 forks source link

Fix using deprecated Gradle methods #167

Closed hfhbd closed 1 year ago

hfhbd commented 1 year ago

Unfortunately, these changes still don't work with Gradle 8, the configuration cache multiplatform tests fail due to https://youtrack.jetbrains.com/issue/KT-55051/MetadataDependencyTransformationTask-is-not-compatible-with-Gradle-configuration-cache

JakeWharton commented 1 year ago

Let's land all these changes except for the Kotlin version bump ahead of time.

JakeWharton commented 1 year ago

Hmm still broken. Weird.

hfhbd commented 1 year ago

Yes, this is expected due to using Gradle 8. I use the renovate Gradle 8 branch as its base and target branch because this update needs manual changes (this PR). But even with these changes the linked KGP issue caused the build to fail because Gradle 8 updated the warning to an error.

Would you like to merge it into main? If so I'll remove the Gradle upgrade.

JakeWharton commented 1 year ago

Oh yeah sorry that's the revert I meant. We can land the other changes in the mean time.

hfhbd commented 1 year ago

Welcome to Gradle 8.0.2!

Why does the CI use Gradle 8.0.2?... https://github.com/hfhbd/licensee/blob/ce3646243839218a6e72937a3e21a3ac4902f255/gradle/wrapper/gradle-wrapper.properties#L3 weird

JakeWharton commented 1 year ago

Very weird. New PR fixed it.