search

cashapp / licensee

Gradle plugin which validates the licenses of your dependency graph match what you expect
https://cashapp.github.io/licensee/docs/1.x/
Apache License 2.0
626 stars 29 forks source link

Fix Gradle 8.1 support #189

Closed hfhbd closed 1 year ago

hfhbd commented 1 year ago

I think this is an upstream issue: configuration.incoming.resolutionResult.rootComponent is a Provider but although we add a mapper during configuration phase, with stable configuration cache using Gradle 8.1 the mapper is called during execution, breaking configuration cache. Previous versions of Gradle called the mapper during configuration phase.

Solution: I extract the usage of dependencies and configurations into variables called during configuration phase.

I couldn't update Gradle to 8.1 because KGP does not support this version. I test it locally with failed tests due to missing KGP support.

JakeWharton commented 1 year ago

I'm back at work this week so I'll get all the latest stuff tested and released here soon.

hfhbd commented 1 year ago

Forgot we already have java only tests to not require KGP support. I will create another PR with a test.