cashapp / licensee

Gradle plugin which validates the licenses of your dependency graph match what you expect
https://cashapp.github.io/licensee/docs/1.x/
Apache License 2.0
614 stars 28 forks source link

Update kotlin monorepo to v1.9.10 - autoclosed #197

Closed renovate[bot] closed 10 months ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jetbrains.kotlin.plugin.serialization (source) 1.9.0 -> 1.9.10 age adoption passing confidence
org.jetbrains.kotlin.js (source) 1.9.0 -> 1.9.10 age adoption passing confidence
org.jetbrains.kotlin.multiplatform (source) 1.9.0 -> 1.9.10 age adoption passing confidence
org.jetbrains.kotlin.jvm (source) 1.9.0 -> 1.9.10 age adoption passing confidence
org.jetbrains.kotlin:kotlin-gradle-plugin (source) 1.9.0 -> 1.9.10 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Release Notes

JetBrains/kotlin (org.jetbrains.kotlin.plugin.serialization) ### [`v1.9.10`](https://togithub.com/JetBrains/kotlin/releases/tag/v1.9.10): Kotlin 1.9.10 ##### Changelog ##### Compiler - [`KT-60769`](https://youtrack.jetbrains.com/issue/KT-60769) Partially revert KT-58371 - [`KT-60659`](https://youtrack.jetbrains.com/issue/KT-60659) Incorrect 'unresolved reference: addFirst' error with JDK 21 - [`KT-60371`](https://youtrack.jetbrains.com/issue/KT-60371) Native custom allocator link error - [`KT-60986`](https://youtrack.jetbrains.com/issue/KT-60986) Native: static caches with custom runtime options are broken on Linux - [`KT-60770`](https://youtrack.jetbrains.com/issue/KT-60770) Fix false-positive ABSTRACT_MEMBER_NOT_IMPLEMENTED on toArray with JDK 21 - [`KT-60231`](https://youtrack.jetbrains.com/issue/KT-60231) NoClassDefFoundError: $$$$$NON_LOCAL_RETURN$$$$$ after upgrade to Kotlin 1.9.0 ##### JavaScript - [`KT-60785`](https://youtrack.jetbrains.com/issue/KT-60785) KJS: Destructured value class in suspend function fails with Uncaught TypeError: can't convert to primitive type error - [`KT-60852`](https://youtrack.jetbrains.com/issue/KT-60852) Kotlin JS(IR): IllegalArgumentException: Cross module dependency resolution failed when updating to Kotlin 1.9.0 - [`KT-57509`](https://youtrack.jetbrains.com/issue/KT-57509) KJS: Compiler generates native JS operator == for comparing values with Any type ##### Native - [`KT-60230`](https://youtrack.jetbrains.com/issue/KT-60230) Native: "unknown options: -ios_simulator_version_min -sdk_version" with Xcode 15 beta 3 - [`KT-60758`](https://youtrack.jetbrains.com/issue/KT-60758) Native: Building for 'iOS-simulator', but linking in dylib built for 'iOS' in Xcode 15 beta 4 ##### Native. C and ObjC Import - [`KT-59167`](https://youtrack.jetbrains.com/issue/KT-59167) Native: cinterop is unable to build interop libraries against the Xcode 15 Beta 1 ##### Tools. Gradle - [`KT-61147`](https://youtrack.jetbrains.com/issue/KT-61147) Kotlin Compiler 1.9.0 bundles a stripped unshadowed version of Gson - [`KT-60543`](https://youtrack.jetbrains.com/issue/KT-60543) NoClassDefFoundError for com/gradle/scan/plugin/BuildScanExtension ##### Checksums | File | Sha256 | | --- | --- | | kotlin-compiler-1.9.10.zip | 7d74863deecf8e0f28ea54c3735feab003d0eac67e8d3a791254b16889c20342 | | kotlin-native-linux-x86\_64-1.9.10.tar.gz | 1db3679919f4449514e9d82451e7dfa73558ac9bc80b82579cd74d452c8faa5b | | kotlin-native-macos-x86\_64-1.9.10.tar.gz | f5650f2560438a692803d8fe07124529c19f1972f84fe09cfa2329b93f43828d | | kotlin-native-macos-aarch64-1.9.10.tar.gz | d2cf5a484ac0808ab29fd3f6099df7c07330f81f3cbab949947e42e36138c3de | | kotlin-native-windows-x86\_64-1.9.10.zip | a34d56661455e94e1ba4dd09ec3c1adac6148fdedcf55eefb9a79c8ed01ff02c |

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.



This PR has been generated by Mend Renovate. View repository job log here.

JakeWharton commented 1 year ago

@hfhbd This unexpected success of the 8.1 test case means we can move forward with these upgrades now, right?

hfhbd commented 1 year ago

Not really, I tried to update Gradle and Kotlin: https://github.com/hfhbd/licensee/pull/7 and https://github.com/hfhbd/licensee/pull/8/commits/1171c3a9a5e131fc2df047fafa264de2c9088be5 but I still get some failures, mostly due to broken js dependencies For example plugin-kotlin-js test:

expected:
    [
        {
            "groupId": "com.example",
            "artifactId": "example",
            "version": "1.0.0",
            "spdxLicenses": [
                {
                    "identifier": "Apache-2.0",
                    "name": "Apache License 2.0",
                    "url": "https://www.apache.org/licenses/LICENSE-2.0"
                }
            ]
        }
    ]

but was:
    [
        {
            "groupId": "org.jetbrains.kotlin",
            "artifactId": "kotlin-dom-api-compat",
            "version": "1.9.0",
            "name": "Kotlin Dom Api Compat",
            "spdxLicenses": [
                {
                    "identifier": "Apache-2.0",
                    "name": "Apache License 2.0",
                    "url": "https://www.apache.org/licenses/LICENSE-2.0"
                }
            ],
            "scm": {
                "url": "https://github.com/JetBrains/kotlin"
            }
        }
    ]
hfhbd commented 10 months ago

Okay, found the errors:

  1. Kotlin 1.9.0 depends on the dom-api-compat dependency, which is published with Gradle metadata as variant.
  2. But the https://repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-common/1.9.0/ isn't published with Gradle metadata.
  3. KGP MPP 1.9.0 depends on AGP 8, so MPP builds with android targets are broken, until there is a PR adding the android namespace (will do it in a few moments).

I changed the logic to fix error 1, but the (broken) stdlib-common isn't always included in licensee reports.