search

cashapp / misk

Microservice Kontainer
https://cashapp.github.io/misk/
Apache License 2.0
399 stars 169 forks source link

Update replica fallback logic #3263

Closed aparajon closed 4 months ago

aparajon commented 4 months ago

This PR does the following:

  1. Removes Vitess from the canRecoverOnReplica path. This is currently causing an issue where a replica gets mistakenly used for performing writes.
  2. Update error logs for when the data source fails to initialize. The current logs seem misleading since they indicate that a replica will always be attempted to fallback to, despite the fallback only applying to a subset of DB types.