cashapp / misk

Microservice Kontainer
https://cashapp.github.io/misk/
Apache License 2.0
399 stars 169 forks source link

Remove unused `clock` parameter from `FakeJob` that causes a breaking ABI change #3279

Closed mpeyper closed 4 months ago

mpeyper commented 4 months ago

The changes in #3252 introduced a new argument to FakeJob that is a breaking API/ABI change, but the argument was not actually being used.

This change removes it again as it's blocking some dependency updates due to incompatible ABI errors. Note that this could be an breaking ABI change for any consumer that have updated to the new API already.