cashapp / misk

Microservice Kontainer
https://cashapp.github.io/misk/
Apache License 2.0
399 stars 169 forks source link

Don't block .md PRs from merging #3281

Closed ean5533 closed 4 months ago

ean5533 commented 4 months ago

It is a known problem that using paths-ignore to skip a workflow step will block a PR from ever merging if that workflow step is required. The step will just be pending forever.

The official guidance from GH is to create a separate workflow that targets the inverse of paths-ignore and just does nothing to complete the required steps. That sounds like a terrible workaround to me; I think it's better if we just remove the ignore rule and eat the unnecessary build cost.

Completely independent of the problem described above, I think we should use paths-ignore on the master branch push rule, that way we can skip unnecessary master builds for .md changes.