cashapp / misk

Microservice Kontainer
https://cashapp.github.io/misk/
Apache License 2.0
402 stars 170 forks source link

Write an optional request logging interceptor that spits out httpd-format access logs #80

Open mmihic opened 6 years ago

mmihic commented 6 years ago

Lots of tools process apache httpd2 access logs, and it's handy for debugging. Would be useful to have an interceptor that emits this log file.

jjestrel commented 5 years ago

from @ryanhall07 : I don’t think the default should be log everything truncated something like log all errors (up to a rate limiter) and maybe a random sample of success requests (edited) also it should be easy to quickly enable/disable these features in real time if i’m actively debugging an issue and “error” should really be anything not ideal, like an error code or a long request eventually we’d probably want all those configs/overrides backed by feature flags

-- something like default % sample success requests, and rate limit errors, then have overrides per endpoint

mmihic commented 5 years ago

/cc @jmuia