cashapp / paparazzi

Render your Android screens without a physical device or emulator
https://cashapp.github.io/paparazzi/
Apache License 2.0
2.25k stars 213 forks source link

New resource loading doesn't doesn't re-run tests when resources change #1300

Closed ansman closed 6 months ago

ansman commented 6 months ago

Description The new resource loading mechanism doesn't correctly register the resource contents as inputs to the test task, leading to potential failures when resources change.

I'm not sure if this is only an issue when using non transitive resources.

Steps to Reproduce A simple reproducer is:

  1. Create two modules, A and B
  2. Enable non transitive resources
  3. Make A depend on B
  4. Add a resource in B
  5. Add a screenshot test in A that use that resource
  6. Record the screenshot
  7. Change the resource in B
  8. Run verification

Expected behavior When a resource is deleted, added or changed tests should re-run.

Additional information:

ansman commented 6 months ago

Ah, this was fixed in #1247