search

cashapp / paparazzi

Render your Android screens without a physical device or emulator
https://cashapp.github.io/paparazzi/
Apache License 2.0
2.24k stars 212 forks source link

Bump LayoutLib to Iguana #1314

Closed jrodbx closed 4 months ago

jrodbx commented 5 months ago

Iguana provides API 34 support!

gabrielittner commented 5 months ago

When I tried Iguana with the rc I also needed this change https://github.com/cashapp/paparazzi/pull/1228/commits/67b23528a1e450280d00f0885d8576d6be6b3302 (more detailed description is in https://github.com/cashapp/paparazzi/pull/1228)

gabrielittner commented 5 months ago

Forgot this one, the icu file name changed: https://github.com/cashapp/paparazzi/pull/1228/commits/9ddb14736cbc01cbf18d593209416d2083069e5f

gabrielittner commented 5 months ago

I've rebased the non Jellyfish specific changes from my pr on top of this and it makes all tests pass. These are the changes: https://github.com/cashapp/paparazzi/compare/jrod/2024-03-01/layoutlib-iguana...freeletics:paparazzi:layoutlib-iguana.

The last commit, to change the macOS runner to the M1 based ones, is more of a workaround than an actual solution though. There are 3 tests that fail only on Intel based macOS (composeA11y, customFontsInCode, customFontsInXml). From some testing on our codebase Iguana and Jellyfish seem generally more inconsistent between platforms, not sure if there is something paparazzi can do about that.

MedetZhakupov commented 4 months ago

@jrodbx this is the release I am waiting for 2 weeks now :).

jrodbx commented 4 months ago

@jrodbx this is the release I am waiting for 2 weeks now :).

On it! Will finish this up this week.

geoff-powell commented 4 months ago

@jrodbx I took @gabrielittner suggestions and tried to fixup iguana in this branch.

CI is passing now but the one strange thing is that the system ui renders differently in the snapshots then what is expected looking at Preview in Android Studio.

jrodbx commented 4 months ago

Quick status update: still actively on this, in the weeds of Choreographer and animations, taking notes to share knowledge to hopefully make future migrations easier.

MedetZhakupov commented 4 months ago

Hoping for the release soon 🚀

TWiStErRob commented 4 months ago

In the meantime, you can give 1.3.4-SNAPSHOT a spin, and report any issues.