Open VirtualParticle opened 3 months ago
Is it considered blocker for the release 1.3.4 @adamalyyan ?
I don't think this would be considered a blocker but I'll defer to @geoff-powell as his PR will resolve this!
Ya I think this might not make 1.3.4. Need to figure out a better way to render accessibility information in a layout so we can correctly measure the details view.
Description Using the
AccessibilityRenderExtension
is useful for analyzing accessibility information, but the information added to the side of the screenshot is cropped out when theSHRINK
rendering mode is used.Steps to Reproduce Here is an example test:
Expected behavior I would expect for the accessibility information on the side of the screenshot to be included in the cropped screenshot, that is to say that the crop would take into account the size of the accessibility information, even if it was taller than the actual content.
Additional information:
Screenshots Screenshot using![image](https://github.com/cashapp/paparazzi/assets/20135416/c12ad84e-838e-434e-81eb-c35a594cdfaf)
SHRINK
:Screenshot using![image](https://github.com/cashapp/paparazzi/assets/20135416/0d845e92-63df-42ae-964d-419d309c7ba8)
NORMAL
:I've given fixing this a look and it seems like one of the challenges here is that the accessibility information is a canvas element which can't easily use things like
WRAP_CONTENT
.