Closed jrodbx closed 3 months ago
I became very curious as to why https://github.com/cashapp/paparazzi/pull/1351 required changes to PaparazziViewOwners. So I investigated a bit around the change history for the Compose 1.4.7 bump in https://github.com/cashapp/paparazzi/pull/856/files#diff-112fc9e73140a9f4004fd54b655b5bad6142ce8a54d94134cac089de4c723716.
PaparazziViewOwners
Note that all the libs had binary AND name changes, except for androidx-activity-1.5.0.jar which only had a binary change. That seemed odd.
Checking the pom dependencies for androidx.compose.ui:ui:1.4.3 (also bumped in that PR), shows that this should have a dependency on activity-1.7.0.
So I introspected the jar in Android Studio and confirmed the issue: I upgraded but incorrectly used the same version/name for the jar :facepalm:
Good thing is that #1351 will take care of this going forward!
I became very curious as to why https://github.com/cashapp/paparazzi/pull/1351 required changes to
PaparazziViewOwners. So I investigated a bit around the change history for the Compose 1.4.7 bump in https://github.com/cashapp/paparazzi/pull/856/files#diff-112fc9e73140a9f4004fd54b655b5bad6142ce8a54d94134cac089de4c723716.Note that all the libs had binary AND name changes, except for androidx-activity-1.5.0.jar which only had a binary change. That seemed odd.
Checking the pom dependencies for androidx.compose.ui:ui:1.4.3 (also bumped in that PR), shows that this should have a dependency on activity-1.7.0.
So I introspected the jar in Android Studio and confirmed the issue: I upgraded but incorrectly used the same version/name for the jar :facepalm:
Good thing is that #1351 will take care of this going forward!