cashapp / paparazzi

Render your Android screens without a physical device or emulator
https://cashapp.github.io/paparazzi/
Apache License 2.0
2.32k stars 216 forks source link

Tests not retreived from cache when project is relocated #1570

Open ribafish opened 2 months ago

ribafish commented 2 months ago

Paparazzi is supplying a bunch of absolute paths to all of test tasks system properties here and here, which means that relocatability is broken when using the paparazzi plugin... This is causing cache misses when project is relocated and the absolute paths change, which also renders remote cache unusable for this purpose, as different machines usually have different absolute paths. This issue affects all test tasks in projects where paparazzi plugin is applied, regardless of whether they actually have paparazzi tests.

Steps to Reproduce

  1. Run a build with paparazzi plugin applied
  2. Move/copy the project to a different location
  3. Run a second build with paparazzi plugin applied
  4. Observe the test tasks were executed with no code changes, in which case you'd expect to get them from cache.

Expected behavior Applying the paparazzi plugin doesn't break caching of test tasks.

Additional information: