cashapp / paparazzi

Render your Android screens without a physical device or emulator
https://cashapp.github.io/paparazzi/
Apache License 2.0
2.32k stars 216 forks source link

Fix window manager view rendering Material3 Compose Bottom Sheet over AccessibilityRenderExtension info. #1634

Closed geoff-powell closed 1 month ago

geoff-powell commented 1 month ago

Description When bumping LayoutLib dependency to 14.0.11+, Material3 bottom sheets render overtop the render extension metadata. This issue is to investigate a possible fix. Ignoring the test modalBottomSheetMaterial3 in this LayoutLib bump PR till this issue is resolved. Image

Steps to Reproduce

Expected behavior Snapshot is unchanged.

Additional information:

Screenshots See above

jrodbx commented 1 month ago

@geoff-powell since this is a known regression, can we get this fix in for 1.3.5?

geoff-powell commented 1 month ago

@geoff-powell since this is a known regression, can we get this fix in for 1.3.5?

Yeah, let me take a look at this today

geoff-powell commented 1 month ago

WindowManagerImpl change is the root cause from 14.0.9 -> 14.0.11. (line 105) https://www.diffchecker.com/fHBDkOTq/