cashapp / redwood

Multiplatform reactive UI for Android, iOS, and web using Kotlin and Jetpack Compose
https://cashapp.github.io/redwood/0.x/docs/
Apache License 2.0
1.63k stars 70 forks source link

This should be a Box. #1524

Open github-actions[bot] opened 1 year ago

github-actions[bot] commented 1 year ago

https://api.github.com/cashapp/redwood/blob/8a90744632cc3e5183e02bc6a0f2cc600b981ad7/test-app/presenter/src/commonMain/kotlin/com/example/redwood/testing/presenter/TestApp.kt#L45


  } else {
    val onBack = { screen.value = null }
    BackHandler(onBack = onBack)
    Column(width = Fill, height = Fill) {
      Button("Back", onClick = onBack)

      // TODO This should be a Box.
      Column(
        width = Fill,
        horizontalAlignment = Stretch,
        modifier = Modifier.grow(1.0).horizontalAlignment(Stretch),
      ) {
        activeScreen.Show(httpClient)
      }
    }
  }
}
JakeWharton commented 1 year ago

Blocked by #900

JakeWharton commented 6 months ago

Blocked only by DOM Box. Even if iOS Box has bugs we can still switch.

JakeWharton commented 2 weeks ago

iOS Box is all good now. Blocked by DOM box only.