search

cashapp / sqldelight

SQLDelight - Generates typesafe Kotlin APIs from SQL
https://cashapp.github.io/sqldelight/
Apache License 2.0
6.13k stars 513 forks source link

Stable sqldelight (0.7.0) incompatible with recent Room versions #991

Closed tellypresence closed 5 years ago

tellypresence commented 5 years ago

Unable to update AAC/Jetpack "Room" beyond 1.0.0 (e.g. 1.1.0 and 1.1.1 fail to build) due to updated SupportSQLiteStatement e.g.:

          error: close() in SqlDelightStatement cannot implement close() in Closeable
          final class <my_sql_query> extends SqlDelightStatement {
              overridden method does not throw Exception

Release of 1.0.0 (alpha) may take some time, so in the meantime please patch the latest stable version 0.7.0 so it can continue to coexist with latest AAC dependency versions.

JakeWharton commented 5 years ago

We're about to release the first RC of 1.0 today (or tomorrow) and all efforts are on it. Updating to 1.1.0 is complicated because it adds a new method to the interface which we cannot support. See https://github.com/square/sqldelight/pull/909#issuecomment-415885436 for more info.

tellypresence commented 5 years ago

Update: sqldelight 0.7.1 now available which allows updating AAC "Room" to latest version

JakeWharton commented 5 years ago

It's the SQlite abstraction version, not Room.

On Sun, Nov 11, 2018, 3:05 PM Steve M <notifications@github.com wrote:

Update: sqldelight 0.7.1 now available which allows updating AAC "Room" to latest version

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/square/sqldelight/issues/991#issuecomment-437700213, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEXZudYUsVnWAlX9BjLIoF4ThUM5rks5uuIMYgaJpZM4XIxio .