search

cashapp / zipline

Run Kotlin/JS libraries in Kotlin/JVM and Kotlin/Native programs
Apache License 2.0
1.98k stars 151 forks source link

Use `AutoCloseable` where appropriate #1343

Open JakeWharton opened 2 weeks ago

JakeWharton commented 2 weeks ago

Refs #999

swankjesse commented 2 weeks ago

Hmmmm

FirZiplineApiReaderTest > happyPath FAILED
    java.lang.IllegalStateException: unexpected class: void
        at app.cash.zipline.api.validator.fir.FirZiplineApiReader.asString(FirZiplineApiReader.kt:147)
        at app.cash.zipline.api.validator.fir.FirZiplineApiReader.asDeclaredZiplineFunction(FirZiplineApiReader.kt:131)
        at app.cash.zipline.api.validator.fir.FirZiplineApiReader.bridgedFunctions(FirZiplineApiReader.kt:108)
        at app.cash.zipline.api.validator.fir.FirZiplineApiReader.asDeclaredZiplineService(FirZiplineApiReader.kt:92)
        at app.cash.zipline.api.validator.fir.FirZiplineApiReader.read(FirZiplineApiReader.kt:77)
        at app.cash.zipline.api.validator.fir.FirZiplineApiReaderKt.readFirZiplineApi(FirZiplineApiReader.kt:51)
        at app.cash.zipline.api.validator.fir.FirZiplineApiReaderTest.happyPath(FirZiplineApiReaderTest.kt:38)
JakeWharton commented 2 weeks ago

Yeah the FIR is seeing the Java close now. I punted until after I finish the Kotlin 2 stuff.