Expense amount able to set to negative numbers

[cashewnade]

The command "add d/gundam t/2022-03-23 a/-15" ran without throwing an error, which should not be the case as expenses should be positive numbers.

[nus-se-script]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to add a negative amount for add command

Steps to reproduce:

Similar to Issue #4 on the edit command.

User is able to add a negative amount when adding an expense into the app.

add d/testing negative a/-1 t/2022-04-16

Expected:

A non-negative amount when adding an expense.

Actual:

---

_{[original: nus-cs2103-AY2122S2/pe-interim#726] [original labels: type.FunctionalityBug severity.High]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Rejected because it is a feature flaw, not a functionality bug. In addition, this feature flaw will not affect the functionality of the application, it will just render one expense invalid due to negative value and user can re-key the value. Hence, the severity should not be high too.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: There should be enforcements done by the team to ensure that expenses entered by users are non-negative. If the user makes the mistake and the application does not remind them, it could lead to serious money management when it comes to large sums. It does cause inconvenience to most, if not all users.

---

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---