search

cashshuffle / cashshuffle-electron-cash-plugin

Electron cash cash-shuffle plugin
27 stars 13 forks source link

Fixed index out-of-range for newly generated wallets #34

Closed jasonbcox closed 5 years ago

jasonbcox commented 5 years ago

Tried cashshuffle on a brand new wallet to find that shuffle would constantly crash until initial funds were confirmed. Tested manually to confirm the fix (there's no test coverage for this portion of code by the looks of it)

jasonbcox commented 5 years ago

Fixes #33

jasonbcox commented 5 years ago

Looks like the merge conflict was caused because a fix was pushed around the time I made the PR: 209fd458821af98077fd07ee95c9ee8dae4c560b The fix doesn't include changes to the other _as_string method though.

jasonbcox commented 5 years ago

Updated the diff to include the other method (which appears to not be used).

clifordsymack commented 5 years ago

@jasonbcox Thanks a lot for your activity! Join the project!