search

cashshuffle / cashshuffle-electron-cash-plugin

Electron cash cash-shuffle plugin
27 stars 13 forks source link

Instructions in README.md are dangerous #36

Closed EchterAgo closed 6 years ago

EchterAgo commented 6 years ago

The installation instructions result in an Electron Cash version 3.0 installation. Version 3.0 was released December of last year and is still affected by the JSONRPC security vulnerability. The instructions should be updated, I'd recommend removing information on how to install Electron Cash and only keeping information on how to install the plugin into an existing Electron Cash installation.

EchterAgo commented 6 years ago

Generally the plugin installation process seems to be a lot smoother nowadays. I just posted on Electron-Cash/Electron-Cash/issues/869 about how to install the plugin and those instructions likely work for all platforms. Consider the text public domain, feel free to copy it.

clifordsymack commented 6 years ago

Hi @EchterAgo !

Thanks for this comment. I will update the installation part on README.

EchterAgo commented 6 years ago

@chaintip 100 days

clifordsymack commented 6 years ago

Updated.

EchterAgo commented 6 years ago

If you reopen this and close it with a pull request you can claim the tip I sent.

chaintip commented 6 years ago

0.00909355 BCH| ~ 4.96 USD has now been claimed by @clifordsymack when pull request #37 was merged. This will be sent to your wallet once you link it with chaintip.