search

cashshuffle / cashshuffle-electron-cash-plugin

Electron cash cash-shuffle plugin
27 stars 13 forks source link

Make sure change address is required #6

Closed checksum0 closed 6 years ago

checksum0 commented 6 years ago

Make sure a change address is required, or auto-selected, or fail gracefully when the output is not exactly equal to the shuffling amount + miner fee.

Right now the plugin will shuffle, abandoning the change as miner fee if a change address is not entered.

You can see https://bch.btc.com/72c0c7da0eeeb695db3dee5f1a8baf644b5db8bb98fb32294d064ddcc270cb30 how someone lost .01 BCH in this shuffling round.

Regards.

zquestz commented 6 years ago

This one is important to fix quickly. We should prioritize this.

checksum0 commented 6 years ago

IMHO, this is fixed for now, considering this is an alpha release as change is sent back to the input if no change address is selected.

Commit ebecf26 fixed this