cashubtc / cashu-ts

A TypeScript library for building Cashu wallets
MIT License
57 stars 33 forks source link

Return unused proofs as change in send function #22

Closed gandlafbtc closed 1 year ago

gandlafbtc commented 1 year ago

https://github.com/cashubtc/cashu-ts/blob/main/src/CashuWallet.ts?plain=1#L96

It might be better to return proofs that enter the method but are not sent to the mint with the change

BilligsterUser commented 1 year ago

do you mean https://github.com/cashubtc/cashu-ts/blob/main/src/CashuWallet.ts#L103 ?

gandlafbtc commented 1 year ago

no, i mean L96, because that's where the proofs get skipped if too many are passed in. They don't get sent to the mint but also not returned as change. i think they should be returned as change

BilligsterUser commented 1 year ago

ahh ok