search

cashubtc / cdk

Cashu Development Kit
MIT License
87 stars 45 forks source link

rename `get_melt_bolt11_quote` #424

Closed tdelabro closed 3 weeks ago

tdelabro commented 1 month ago

From crates/cdk-axum/src/lib.rs

        .route("/melt/quote/bolt11", post(get_melt_bolt11_quote))

isn't it weird that a POST route calls a method named get_<...>? It's at least confusing.

Couldn't it be created post_melt_bolt11_quote or create_melt_bolt11_quote

mubarak23 commented 1 month ago

yaah, maybe the function name should change, but create_melt_bolt11_quote can be abit off the curve, since the function return MeltQuoteBolt11Response and accept melt_request: &MeltQuoteBolt11Request

thesimplekid commented 3 weeks ago

Yeah a rename to post_... would make more sense.

mubarak23 commented 3 weeks ago

Yeah a rename to post_... would make more sense.

I will send PR for this