search

cashubtc / cdk

Cashu Development Kit
MIT License
87 stars 44 forks source link

Abstract HttpClient into HttpClientMethods trait #429

Closed davidcaseria closed 3 weeks ago

davidcaseria commented 3 weeks ago

This decouples the HTTP client implementation from the Wallet by allowing a CDK user to inject a custom HTTP client if desired.

This should also help with unit testing of the Wallet in the future.

davidcaseria commented 3 weeks ago

@thesimplekid it seems to me that the CI errors are existing errors. Are they safe to ignore?

ok300 commented 3 weeks ago

I think I found a way to fix at least some of the failing CI checks: https://github.com/davidcaseria/cdk/pull/2

ok300 commented 3 weeks ago

I might have a few more CI fixes: https://github.com/davidcaseria/cdk/pull/3

davidcaseria commented 3 weeks ago

@ok300 I appreciate the fixes!