search

cashubtc / eNuts

A Cashu wallet for Android and iOS 🥜🐿️
https://enuts.cash
GNU General Public License v3.0
189 stars 25 forks source link

Wrong swipe back after token creation #194

Closed dtonon closed 1 year ago

dtonon commented 1 year ago

Describe the bug After creating a token, if the user in the last view swipes back, he is brought back to the "Cashu is beeing created" view.

To Reproduce Steps to reproduce the behavior:

  1. Use Send and create a token
  2. In the last view swipe back (right to left from the right edge)

Expected behavior The user should be brought to the home.

Desktop (please complete the following information):

dtonon commented 1 year ago

@KKA11010 pay attention to the fact that the issue has been labeled "IOS" while I tested it on Android.

KKA11010 commented 1 year ago

Oh ok thank you for the hint 🥇

swedishfrenchpress commented 1 year ago

I was able to reproduce this on Android but not on iOS. Android has that unique "swipe right to left" to go back. Screenshot_20230913-231410 Screenshot_20230913-231414

swedishfrenchpress commented 1 year ago

Looks like this has been fixed in the latest version @KKA11010 https://github.com/cashubtc/eNuts/assets/78821053/c747529d-aec9-4a41-ac95-ead373ba8ab4

KKA11010 commented 1 year ago

Looks like this has been fixed in the latest version @KKA11010 https://github.com/cashubtc/eNuts/assets/78821053/c747529d-aec9-4a41-ac95-ead373ba8ab4

Ok, Thank you for testing out 🥇

swedishfrenchpress commented 1 year ago

Tested in following screens too. It worked on the following three:

However, I wasn't able to test on the dashboard.

KKA11010 commented 1 year ago

Tested in following screens too. It worked on the following three:

* new cashu token

* success screen

* processing screen (the loading screen right before success or new cashu token)

However, I wasn't able to test on the dashboard.

* dashboard (was going back to PIN screen)
  I think because I'm running eNuts on the Expo Go app i can't fully test this. When I swipe back it takes to me the ExpoGo app screen.

It is the correct behavior, it does not take you from dashboard back to the pin screen but out of the app and that is ok i guess 👍