search

cashubtc / nuts

Cashu protocol specifications https://cashubtc.github.io/nuts/
MIT License
143 stars 49 forks source link

fix a typo for nut08 #60

Closed biluohc closed 11 months ago

callebtc commented 11 months ago

Thanks for the PR but we can't merge this. This isn't a typo but renaming a field and would break the protocol.

@thunderbiscuit is right that we want to rename this field to a more generic name request which can harbor lightning invoices, on-chain addresses, or whatever else we might encounter along the way.

biluohc commented 11 months ago

https://github.com/cashubtc/nuts/blob/main/08.md#example-1

So what is Everything here is the same as in [NUT-05](https://github.com/cashubtc/nuts/blob/main/05.md) except for outputs. ?

thesimplekid commented 11 months ago

So what is Everything here is the same as in NUT-05 except for outputs. ?

Yes, it allows for change to be returned if the routing fee is over paid.