cashubtc / nuts

Cashu protocol specifications https://cashubtc.github.io/nuts/
MIT License
143 stars 49 forks source link

Nut11 test vectors and nut fixes #96

Closed thesimplekid closed 4 months ago

thesimplekid commented 6 months ago

Some test vectors for NUT11 but two things I think should be discussed and clarified in the nut before merging.

1) Should the pubkey be the 33 byte key with a a prefix 02/03 or the 32 byte key without the prefix. I lean towards enforcing the 32 byte. 2) What signature/signatures are required on the blinded messages when there are multiple proofs with different conditions. This one is a bit more complicated as there could also be multi-sig proofs. Simplest would be to require a single signature from any of the pubkeys in the proofs.

callebtc commented 6 months ago
  1. Should the pubkey be the 33 byte key with a a prefix 02/03 or the 32 byte key without the prefix. I lean towards enforcing the 32 byte.

I think I agree. Two reasons come to mind:

callebtc commented 5 months ago

Gorgeous work!