search

cashubtc / nutshell

Chaumian ecash wallet and mint for Bitcoin
https://docs.cashu.space
MIT License
379 stars 95 forks source link

[wallet] Witness should be null not an empty string #559

Closed thesimplekid closed 4 months ago

thesimplekid commented 4 months ago

If a witness is not required on the proof it should be null not an empty string. This is causing deserialization to fail in CDK. image

https://github.com/cashubtc/nutshell/blob/75987beaf19897175f2be98151cb3c8cfba839ce/cashu/core/base.py#L109

callebtc commented 4 months ago

Thanks for noticing.