casid / jte

Secure and speedy templates for Java and Kotlin.
https://jte.gg
Apache License 2.0
754 stars 56 forks source link

add include and exclude patterns to jte-model (#243 Part 2) #245

Closed chkl closed 1 year ago

chkl commented 1 year ago

As suggested in #243

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.23 :warning:

Comparison is base (6a8da53) 91.20% compared to head (e677593) 90.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #245 +/- ## ============================================ - Coverage 91.20% 90.98% -0.23% - Complexity 1166 1169 +3 ============================================ Files 74 74 Lines 3059 3073 +14 Branches 473 475 +2 ============================================ + Hits 2790 2796 +6 - Misses 168 171 +3 - Partials 101 106 +5 ``` | [Impacted Files](https://app.codecov.io/gh/casid/jte/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Hager) | Coverage Δ | | |---|---|---| | [...main/java/gg/jte/models/generator/ModelConfig.java](https://app.codecov.io/gh/casid/jte/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Hager#diff-anRlLW1vZGVscy9zcmMvbWFpbi9qYXZhL2dnL2p0ZS9tb2RlbHMvZ2VuZXJhdG9yL01vZGVsQ29uZmlnLmphdmE=) | `69.23% <50.00%> (-30.77%)` | :arrow_down: | | [...n/java/gg/jte/models/generator/ModelExtension.java](https://app.codecov.io/gh/casid/jte/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Hager#diff-anRlLW1vZGVscy9zcmMvbWFpbi9qYXZhL2dnL2p0ZS9tb2RlbHMvZ2VuZXJhdG9yL01vZGVsRXh0ZW5zaW9uLmphdmE=) | `66.66% <71.42%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/casid/jte/pull/245/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Hager)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

casid commented 1 year ago

Looks good to me! @edward3h, you know the model extension a lot better, I'd say you should have the final say before merge :-)

As with the other PR, maybe we could add a test for this, possibly integration test as it touches through all layers? There are test/jte-runtime-cp-test-models(for Maven) and test/jte-runtime-cp-test-models-gradle (for Gradle), which could get configured with the new patterns.

kelunik commented 1 year ago

Also, this PR includes both changes now. We should either remove them or close #244.