Closed chkl closed 1 year ago
Patch coverage: 60.00
% and project coverage change: -0.23
:warning:
Comparison is base (
6a8da53
) 91.20% compared to head (e677593
) 90.98%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks good to me! @edward3h, you know the model extension a lot better, I'd say you should have the final say before merge :-)
As with the other PR, maybe we could add a test for this, possibly integration test as it touches through all layers? There are test/jte-runtime-cp-test-models
(for Maven) and test/jte-runtime-cp-test-models-gradle
(for Gradle), which could get configured with the new patterns.
Also, this PR includes both changes now. We should either remove them or close #244.
As suggested in #243