casid / jte

Secure and speedy templates for Java and Kotlin.
https://jte.gg
Apache License 2.0
748 stars 56 forks source link

Adds missing developmentMode configuration metadata property. #272

Closed schowave closed 12 months ago

schowave commented 1 year ago

This fixes the issue of spring boots configuration metadata problems.

Currently I cannot run SpringBoot Tests with version 3.1.0, because of the missing property. It would be great, if you could release a bugfix release for that issue. But it is not urgent.

This property was missing in https://github.com/casid/jte/pull/251

schowave commented 12 months ago

@casid do i have to create an issue for this?

casid commented 12 months ago

No, I just did not have time to look into coding the last few days, sorry.

PR looks good, @atomfrede, @tschuehly any objections to merge this?

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.06% :tada:

Comparison is base (f53fb95) 91.01% compared to head (1f9651e) 91.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #272 +/- ## ============================================ + Coverage 91.01% 91.07% +0.06% - Complexity 1181 1182 +1 ============================================ Files 75 75 Lines 3105 3105 Branches 480 480 ============================================ + Hits 2826 2828 +2 + Misses 170 169 -1 + Partials 109 108 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/casid/jte/pull/272/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Hager)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tschuehly commented 12 months ago

@casid LGTM!

casid commented 11 months ago

Sorry for being so late! I finally published a new release containing this fix :-)

schowave commented 11 months ago

Thank you for the release, now my @SpringBootTest Cases are working again :-)