Closed MariusVolkhart closed 6 months ago
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
0c83398
) 91.20% compared to head (f03d977
) 90.83%. Report is 2 commits behind head on main.:exclamation: Current head f03d977 differs from pull request most recent head 85c2f6c. Consider uploading reports for the commit 85c2f6c to get more accurate results
Files | Patch % | Lines |
---|---|---|
...extensionsupport/ExtensionTemplateDescription.java | 0.00% | 8 Missing :warning: |
...untime/src/main/java/gg/jte/runtime/ClassInfo.java | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
Looks good, but could you add small tests to make the codecov report happy?
@marcospereira Thanks for the review, and sorry for making you go through such rookie stuff. I've updated my IDE config for this project to hopefully avoid code style issues in the future. Applied Objects.hash()
as you suggested. @casid tests added.
Thank you!
These types are frequently used in Sets. Accordingly, they'll be hashed, and so should have proper hashCode() and equals() implementations.
The implementations I chose were a best-effort guess as to the identity of the models. ClassInfo was particularly challenging as it has a mutable field and I found it challenging to figure out the difference between the various types of names.