search

casid / jte

Secure and speedy templates for Java and Kotlin.
https://jte.gg
Apache License 2.0
737 stars 54 forks source link

ci: Do not cache locally published artifacts #316

Closed marcospereira closed 6 months ago

marcospereira commented 6 months ago

What?

These workflows publish artifacts to the local maven repository, which are then cached by GH Actions. Removing them at the end of the workflow prevents them from polluting the cache.

Related to https://github.com/casid/jte/pull/310#issuecomment-1884217056.

It would still be good to delete the existing caches before merging this, and check the effect it would have on #310. Deleting the caches is straightforward if you have GH CLI installed:

gh cache delete --all
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7ad2e12) 91.20% compared to head (cd410f2) 91.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #316 +/- ## ========================================= Coverage 91.20% 91.20% Complexity 1211 1211 ========================================= Files 76 76 Lines 3151 3151 Branches 492 492 ========================================= Hits 2874 2874 Misses 164 164 Partials 113 113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

casid commented 6 months ago

@marcospereira it seems the windows build is still failing?

marcospereira commented 6 months ago

@marcospereira it seems the windows build is still failing?

This is good to go now. :-)

casid commented 6 months ago

Thank you @marcospereira!