casid / jte

Secure and speedy templates for Java and Kotlin.
https://jte.gg
Apache License 2.0
737 stars 54 forks source link

Fix models extension code generation for tags/templates in subfolders #324

Closed marcospereira closed 6 months ago

marcospereira commented 6 months ago

What

When generating code, the jte-models extension does not use the fully-qualified class name for tags/templates in subfolders (therefore, sub-packages). This results in compilation errors.

Also, it adds a new Gradle project that:

Having a project is better than simply adding more unit tests since it will mimic the experience users have. The new test project is a copy of test/jte-runtime-cp-test-models-gradle, but adapted for Kotlin.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ce83cc9) 91.23% compared to head (23652e4) 91.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #324 +/- ## ========================================= Coverage 91.23% 91.23% Complexity 1216 1216 ========================================= Files 76 76 Lines 3159 3159 Branches 492 492 ========================================= Hits 2882 2882 Misses 164 164 Partials 113 113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

casid commented 6 months ago

Wow, that was quick. Thank you for fixing this @marcospereira.

marcospereira commented 6 months ago

Wow, that was quick. Thank you for fixing this @marcospereira.

Thanks! I think it would be good to have 3.1.8 release to replace the broken 3.1.7. But it is Friday, so if releasing takes too much of your time, maybe just put a note on the 3.1.7 release about the issue. :-)

casid commented 6 months ago

I just released 3.1.8 and left a note on the 3.1.7 release.