search

casid / jte

Secure and speedy templates for Java and Kotlin.
https://jte.gg
Apache License 2.0
844 stars 63 forks source link

jte-spring-boot-starter-3 doesn't depend on jte #381

Closed mhalbritter closed 1 month ago

mhalbritter commented 1 month ago

Hello there!

I've noticed that jte-spring-boot-starter-3 doesn't depend on jte - that means if I only add jte-spring-boot-starter-3 to my project, the auto-configuration doesn't enable, because it's conditional on TemplateEngine, which isn't on the classpath.

The idea behind a starter is that the user only need to add this dependency and it pulls in all other needed dependencies, as described here.

You get a one-stop-shop for all the Spring and related technology that you need without having to hunt through sample code and copy paste loads of dependency descriptors

Would it be possible to add jte as a dependency to jte-spring-boot-starter-3?

casid commented 1 month ago

Hi @mhalbritter,

thanks for the suggestion and the explanation. That makes a lot of sense.

I changed the dependency to non-optional: https://github.com/casid/jte/commit/bdd2fcc75b6198c5bbf7b7ed6dc4ad21e018fbfc

mhalbritter commented 1 month ago

Nice. Thank you!