search

casinocoin / tokenwallet-mobile

CasinoCoin Token Wallet for Mobile
0 stars 0 forks source link

[BUG] Saved contacts are erased when restoring #209

Closed zenkertA closed 4 years ago

zenkertA commented 4 years ago

Describe the bug Contacts saved are erased when restoring

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Contacts'
  2. See error

Expected behavior Saved contacts should be restored too.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

t3nshi commented 4 years ago

lol. This is not a bug your contacts are not saved to the blockchain, are just on your phone. So if you restore from words the contacts, labels, external accounts added, or settings modified won't come back. The words only restore the accounts you create from the wallet started with those words, plus the transactions and keys needed to move the respective coins/tokens around.

zenkertA commented 4 years ago

IMHO it should be saved. Pretty annoying if not.

Den tors 27 feb. 2020 17:36TeNsHi SaMa notifications@github.com skrev:

lol. This is not a bug your contacts are not saved to the blockchain, are just on your phone. So if you restore from words the contacts, labels, external accounts added, or settings modified won't come back. The words only restore the accounts you create from the wallet started with those words, plus the transactions and keys needed to move the respective coins/tokens around.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/casinocoin/tokenwallet-mobile/issues/209?email_source=notifications&email_token=AJOPIZ5TNQ53E3MCDJAQ7ULRE7TZ5A5CNFSM4K4572K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFAVXA#issuecomment-592055004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOPIZ7U47POR7ECUY7ZVCDRE7TZ5ANCNFSM4K4572KQ .

zenkertA commented 4 years ago

Let me add this. If update the normal way in Play or for iOs users. Will the Contacts get erased too? If so. Not good at all.

Den tors 27 feb. 2020 18:57zenkert aahl zenkertaahl@gmail.com skrev:

IMHO it should be saved. Pretty annoying if not.

Den tors 27 feb. 2020 17:36TeNsHi SaMa notifications@github.com skrev:

lol. This is not a bug your contacts are not saved to the blockchain, are just on your phone. So if you restore from words the contacts, labels, external accounts added, or settings modified won't come back. The words only restore the accounts you create from the wallet started with those words, plus the transactions and keys needed to move the respective coins/tokens around.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/casinocoin/tokenwallet-mobile/issues/209?email_source=notifications&email_token=AJOPIZ5TNQ53E3MCDJAQ7ULRE7TZ5A5CNFSM4K4572K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFAVXA#issuecomment-592055004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOPIZ7U47POR7ECUY7ZVCDRE7TZ5ANCNFSM4K4572KQ .

t3nshi commented 4 years ago

Of course not. It is wiped with your info. Keep in mind that I asked you to use the recovery so you could try on both testnet and production, and that the recovery is an extreme measure. You don't have to wipe all your data everytime you update the app. If you just update without wiping it will have the same contacts and settings. Of course, we won't save ever this info on the chain, there should only be the info of transactions, accounts and balances.

zenkertA commented 4 years ago

Ok. Will try that next time. Recovery is the extreme one. I guess not many will do that IRL. Update is the normal procedure. Just as a sidenote. Both Live and Test is fine.

Den tors 27 feb. 2020 21:40TeNsHi SaMa notifications@github.com skrev:

Of course not. It is wiped with your info. Keep in mind that I asked you to use the recovery so you could try on both testnet and production, and that the recovery is an extreme measure. You don't have to wipe all your data everytime you update the app. If you just update without wiping it will have the same contacts and settings. Of course, we won't save ever this info on the chain, there should only be the info of transactions, accounts and balances.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/casinocoin/tokenwallet-mobile/issues/209?email_source=notifications&email_token=AJOPIZ2HKQWWA7JXZKDZSSTRFAQNDA5CNFSM4K4572K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENF34VA#issuecomment-592166484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOPIZ4OQEKFPHPVW4HL6GLRFAQNDANCNFSM4K4572KQ .