search

cask / cask

Project management tool for Emacs
http://cask.readthedocs.io
GNU General Public License v3.0
1.27k stars 147 forks source link

Fix shebang #558

Closed berquist closed 2 years ago

berquist commented 2 years ago

The fix from #14 got lost when bin/cask was first translated to Python and then translated back in d1ee01ba. This puts it back so that Cask works with Nix and other platforms that don't have bash even symlinked in /bin.

dickmao commented 2 years ago

Word.

akirak commented 2 years ago

Note that -S option of env command is only available since coreutils 8.30. Ubuntu 18.04 doesn't support it, so some users may not be able to run the script.

berquist commented 2 years ago

Note that -S option of env command is only available since coreutils 8.30. Ubuntu 18.04 doesn't support it, so some users may not be able to run the script.

Well that's no good. Is it enough to do ye olde #!/usr/bin/env bash; set -euo pipefail; <script contents ...>?

dickmao commented 2 years ago

Ubuntu 18.04 doesn't support it, so some users may not be able to run the script.

True that. Reverted, thanks.

akirak commented 2 years ago

Is it enough to do ye olde #!/usr/bin/env bash; set -euo pipefail; <script contents ...>

Yes, that will be suitable here.

dickmao commented 2 years ago

Awesome, guys. #14 restored in 751435b. Sorry about that.