search

casmlab / stack

The BITS Lab STACK tool for social media collection and analysis.
http://bits.ischool.syr.edu/
MIT License
1 stars 0 forks source link

new error message for terms with no data #10

Closed libbyh closed 7 years ago

libbyh commented 7 years ago

For a term that has no data (i.e., it's collector just started), the error should say "No data for [term] yet. Please check back." Right now, it gives a pop up error that's meaningless to end users and inaccurate for developers (there is a term id, there's just no data associated with it).

screen shot 2017-04-07 at 9 09 37 pm

libbyh commented 7 years ago

Doesn't actually need to be a pop up dialog box at all. Can just be a message inside the view where data will eventually show up.

pratik27shah commented 7 years ago

Ok..wil resolve it right way

pratik27shah commented 7 years ago

issue fixed,check if this is fine. errorvalues

libbyh commented 7 years ago

Close, but "Value not found" still doesn't explain to the user or the dev what the problem is. It should say "No data for that term. Please check back." I see two lines in /app/templates/collector.html - 281 and 335 - that show this error. Do they show it for the same reasons? Why two places?

pratik27shah commented 7 years ago

done

libbyh commented 7 years ago

Should list the actual term instead of the word term - e.g., "No data for defenceupdate".

The item clicked isn't viewable anymore, and we need to remind users what they selected.

pratik27shah commented 7 years ago

ok..

libbyh commented 7 years ago

I still see the generic "No data for the term" message. screen shot 2017-04-11 at 10 16 51 am

pratik27shah commented 7 years ago

its working fine