casonadams / walh

Clean vim color scheme; Uses terminal colors for highlights.
MIT License
14 stars 0 forks source link

Imperceptible colors on Buffer Names #1

Closed wantguns closed 2 years ago

wantguns commented 2 years ago

I think this is the correct place to open the issue, but please let me know if is not. I love the simplicity of this colorscheme, kudos on that.

My only gripe with it is that the unselected buffer name/titles have the same background and the foreground color.

Buffer named style.scss is present but not visible: image

Buffer named style.scss after terminal selection: image

If this is not related to walh, kindly point me to where I should check to get it fixed. Thanks !

casonadams commented 2 years ago

@WantGuns thanks for raising this! What is the plugin you are using for the tab bar?

wantguns commented 2 years ago

Im using barbar -- https://github.com/romgrk/barbar.nvim

casonadams commented 2 years ago

@WantGuns I made an update. I think barbar.nvim is mainstream enough to just include the color highlights it uses into walh. Please have a look and see if it meets your expectations.

Cheers!

wantguns commented 2 years ago

Thanks for the quick fix. I can see the buffer names now ! image

I think this comes to personal preference, but after your commit, the selected buffer has a darker foreground than the unselected buffer which is confusing my trained muscle memory hehe.

casonadams commented 2 years ago

Ah I missed that. I have corrected this with the last commit. Give it a look and lets see if it looks fine on your side.

Thanks

casonadams commented 2 years ago

@WantGuns can you also share your terminal colorscheme thanks!

wantguns commented 2 years ago

Edit: @casonadams I tried switching to a different colorscheme (Hyper) and it looked perfect in that: image I think this has to do with the colorscheme maybe ?


Hey casonadams, I am still facing the same colors on my end after updating the plugin :(

tmux.conf is the selected buffer and its foreground is dimmer than the cpu.tmux buffer title: image

wantguns commented 2 years ago

For the colorscheme, I wanted to go towards something like Hyper (I really like Vercel's color palette), but it seemed over-contrasted and so I went with Tomorrow Night Bright.

The colors for Alacritty are: https://github.com/eendroroy/alacritty-theme/blob/master/themes/tomorrow_night_bright.yaml

casonadams commented 2 years ago

Thanks for sharing the colorscheme. So that colorscheme has color15 which is normally light colors (for a dark scheme). However the white is a darkgrey. Update the following and it will work for you.

    # Default colors
    primary:
      background: '0x000000'
      foreground: '0xeaeaea'

    # Normal colors
    normal:
      black:   '0x000000'
      red:     '0xd54e53'
      green:   '0xb9ca4a'
      yellow:  '0xe6c547'
      blue:    '0x7aa6da'
      magenta: '0xc397d8'
      cyan:    '0x70c0ba'
      white:   '0x424242'

    # Bright colors
    bright:
      black:   '0x666666'
      red:     '0xff3334'
      green:   '0x9ec400'
      yellow:  '0xe7c547'
      blue:    '0x7aa6da'
      magenta: '0xb77ee0'
      cyan:    '0x54ced6'
      white:   '0xeaeaea'

Before change: image

After change: image

The colorscheme can be seen using neofetch

casonadams commented 2 years ago

I have some other colorschemes that seems to be really nice with walh https://github.com/casonadams/alacritty-shell/wiki/Themes

wantguns commented 2 years ago

Thanks a lot for the input and quick fixes, im off to checking out your colorschemes for Alacritty !