search

casouri / eldoc-box

childframe doc for eglot and anything that uses eldoc
361 stars 26 forks source link

Multiple overlapping child frames #101

Closed yrns closed 6 months ago

yrns commented 6 months ago

I run eldoc-box-hover-mode with global tab-line mode enabled. Every time I open a new buffer with the eldoc-box child frame visible, I end up with multiple overlapping child frames. It seems the tab-line mode hook is leaving dangling frames. I redefined it to:

  (defun eldoc-box-reset-frame ()
    (interactive)
    (when eldoc-box--frame
      (delete-frame eldoc-box--frame)
      (setq eldoc-box--frame nil)))

I'm not sure of the purpose of this function, so I can't suggest a better fix.

casouri commented 6 months ago

I think it's the right fix, thanks! I pushed the change.