casouri / eldoc-box

childframe doc for eglot and anything that uses eldoc
342 stars 27 forks source link

Fix eldoc-box--help-at-point-async-update: mapcar -> mapconcat #105

Closed rennsax closed 3 weeks ago

rennsax commented 1 month ago

I had problems when updating the eldoc-box frame until I changed mapcar to mapconcat in eldoc-box--help-at-point-async-update.

concat does not accept a list of strings as its arguments. Is this an unintentional mistake?

casouri commented 3 weeks ago

You're right. Thanks for letting me know! I think using string-join is better since (mapcar #'car docs) will return a list of docs (strings) and we want to join them together with the separator. I pushed a commit fixing it.