casouri / vundo

Visualize the undo tree.
414 stars 21 forks source link

Broken: select node and `RET`(kill-buffer-and window) would make buffer read-only. #10

Closed liuyinz closed 2 years ago

liuyinz commented 2 years ago

It would be better to wrap the kill-buffer-and-window with the

(with-current-buffer vundo--orig-buffer
     (setq-local inhibit-modification-hooks nil
                 buffer-read-only nil))

together, don't use it directly. After all, vundo-quit would invoke it at least.

casouri commented 2 years ago

Thank you! I should've know better. I changed vundo to make the original buffer read-only but didn't update other parts of the code to cooperate. It should be fixed now.

liuyinz commented 2 years ago

Great.