casouri / vundo

Visualize the undo tree.
414 stars 21 forks source link

[PR] more compat with evil and visual-line-mode #9

Closed NightMachinery closed 2 years ago

NightMachinery commented 2 years ago

You might want to incorporate this, or the package will be very unpleasant for people with other configs:

  (defun night/h-vundo-buf-setup (orig-fn &rest args)
    (let ((vundo-buf (apply orig-fn args)))
      (with-current-buffer vundo-buf
        (toggle-truncate-lines 1)
        (evil-insert-state))
      vundo-buf))
  (advice-add 'vundo-1 :around #'night/h-vundo-buf-setup)
ideasman42 commented 2 years ago

This report gives no context, what is the problem this solves? I use evil mode and didn't see the need to enter evil-insert-state for e.g.

NightMachinery commented 1 year ago

You are correct, it no longer seems needed.