casper-astro / mlib_devel

http://casper-toolflow.readthedocs.io/en/latest/jasper_documentation.html
56 stars 86 forks source link

update_casper_blocks doesn't seem to be permanent #202

Closed kiranshila closed 6 months ago

kiranshila commented 1 year ago

So, I have an m2019 model I'm trying to update to the m2021 toolflow.

I update my mlib_devel submodule, run ./startsg, open my model, and run update_casper_blocks(bdroot), let it do its thing (updating 48 blocks), save the simulink model, and close matlab.

When I open things up again, and try to run the same update_casper_blocks it still seems to think there are 48 blocks to update. I'm not sure what to make of this.

jkocz commented 1 year ago

It should always attempt to update all the blocks in the design that can be updated. Could it be that it's not just trying to re-update blocks that don't need it (ie the first update_casper_blocks was successful, and it was saved, it's just re-updating because it doesn't know better)? Or it is the case that the design actively doesn't work unless you do an update blocks each time?

jack-h commented 1 year ago

Yeah, this is correct -- update_casper_blocks knows nothing about whether blocks need to be updated, it just nukes and replaces them all.

On Thu, 3 Aug 2023 at 22:39, J. Kocz @.***> wrote:

It should always attempt to update all the blocks in the design that can be updated. Could it be that it's not just trying to re-update blocks that don't need it (ie the first update_casper_blocks was successful, and it was saved, it's just re-updating because it doesn't know better)? Or it is the case that the design actively doesn't work unless you do an update blocks each time?

— Reply to this email directly, view it on GitHub https://github.com/casper-astro/mlib_devel/issues/202#issuecomment-1664679340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWM7HMFJIACLEHLVSKMELXTQLCHANCNFSM6AAAAAA2QXQQYE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kiranshila commented 1 year ago

How would I know if blocks needed to be updated?

jack-h commented 1 year ago

Not really a satisfying answer, but you'll know they don't need to be updated if you haven't updated your mlib_devel.

On Fri, 4 Aug 2023 at 15:43, Kiran Shila @.***> wrote:

How would I know if blocks needed to be updated?

— Reply to this email directly, view it on GitHub https://github.com/casper-astro/mlib_devel/issues/202#issuecomment-1665728715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWM7G23HWLS63WWUT2PTLXTUDCDANCNFSM6AAAAAA2QXQQYE . You are receiving this because you commented.Message ID: @.***>